Changeset 2225


Ignore:
Timestamp:
Dec 4, 2012, 5:12:29 PM (6 years ago)
Author:
matthijs
Message:

luci: Don't show "Developer's version" for non-dev versions.

The previous check was not sufficient. It relied on lua's truth testing,
which only considers false and nil as untrue. In particular, setting the
"dev" variable to "0" did not make it untrue, so the dashboard would
still show "Developer's version" (even though all other code would
correctly treat this as a non-dev version.

It seems this check was flawed since its introduction in r1731. However,
since there have not been any non-dev releases yet since then, this bug
has not actually surfaced.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/luci/modules/admin-fon/luasrc/view/fon/admin_fon_summary.htm

    r2217 r2225  
    7474                                <%if beta then %><h4>Beta <%=beta%></h4><%end%>
    7575                                <ul>
    76                                         <%if dev then %><li>Developer's version</li><%end%>
     76                                        <%if dev == "1" then %><li>Developer's version</li><%end%>
    7777                                        <li><%:summary_uptime Uptime%>: <%=uptime%></li>
    7878                                </ul>
Note: See TracChangeset for help on using the changeset viewer.