Settings for target device on Download Manager aren't kept

[David Ludovino <david.ludovino@…>]

Under the settings menu for the Download Manager I can set the target device but it only remains what I selected until the rooter is restarted. After a restart it returns to a default value which seems to be the first partition listed in the USB Disc menu.

[matthijs]

I've figured out what causes the problem. When mountd is started at boot and mounts the first disc/partition, it runs /etc/fonstated/SetupDlmd. This script checks to see if the base directory is present, which is not the case, so it looks through /tmp/mounts to find a new base directory. Since there is only one partition mounted at this time, this partition is always selected.

So, that's what causes the problem. Now the question is how to fix this, since I don't think mountd always knows that there are more disks to be mounted. It might just be sufficient to have SetupDlmd? wait for a few seconds before acting (or better, have mountd wait for a few seconds, so it can actually run SetupDlmd? once after all partitions are mounted).

[matthijs]

(In [2095]) luci_dlmanager: Keep a "preferred" and "actual" target device.

Previously, there was only one target device configured. When this device was not available, another device was automatically selected and the previously configured device was forgotten.

This created a problem on reboots, when each partition was mounted in turn. Since the SetupDlmd? script was ran after each partition, the first SetupDlmd? run would always select the first partition as the download device, since no other partitions would be available at that time.

By separating these two values, the actual target device can be autoselected (makeing sure it is always valid), while the preferred device is always the user's choice, allowing the preferred device to be selected if it comes available again later.

Closes: #1079