Transmission and Twitter notification

[anonymous]

I'm testing the new firmware 2.3.7.0 beta2. May it be possible to implement the functionality to add a Twitter notification when a torrent file has been downloaded (on Transmission)?

Thanks

[matthijs]

Sounds nice, though I'm not sure if Transmission is hookable enough. I'll keep this in mind for after 2.3.7.0.

[Paul@…]

I've written a patch for this, it may be no good as I've never written a patch before but it works for me.
A couple of issues

1. I guess the /etc/config/twitter file is backed up on an upgrade? if so I'm not how to handle that, or maybe I updated the wrong file

2. It needs a change to the torrent config file which means it will only work if people reinstall that

3. the location and or name of the /Apps/torrent file may not be ideal? also the patch doesn't seem to make it executable?

[matthijs]

Hey Paul,

thanks for the patch, it looks good! I'll see if I can include this in the 2.3.7.0 release.

1. Yes, see trunk/luci/modules/admin-fon/root/sbin/save-config.sh. However, this also means that any changes to this file in the firmware (e.g., the addition of the new torrent section) will be overwritten with the backed up version as well, but I'll think of something for that.

2. Ah, that's what I said above as well, yes. I'll fix that.

3. Perhaps some other place is indeed better, I'll have a look around to find a better spot. As for making it executable, a diff can't show that, so I'll have to remember to fix that before I commit it.

[matthijs]

Usually when we commit patches made by users, we give them credit in the Subversion log using their full name. If this is not a problem for you, could you tell me your real name?

[Paul@…]

Hi, I'd prefer it didn't include my name if that's okay. Thanks.

[matthijs]

Sure, it's your patch :-)

I've fixed the /etc/config/twitter issue by letting start.sh add the section if it's not present yet, this also prevents the Torrent setting from showing up in the Twitter plugin if the Torrent plugin is not installed yet.

I'm testing this now, if it works, I'll commit the patch this afternoon.

Thanks again for the patch!

[matthijs]

(In [2124]) transmission: Add Twitter notifications for complete downloads.

The first time Transmission is started, an option is added to the Twitter plugin for torrent notifications. This option is enabled by default and sends a Twitter message on every completed message.

Closes: #1158