WAN static IP lost after using 3G connection

[mihaly.reg@…]

F2G 2.3.0.1 RC1. Static IP configured on WAN. Then 3G modem is connected, WAN disconnected, reboot F2. 3G is working. But if plugging out 3G and connecting the WAN cable the Static IP setting is replaced by DHCP. Selecting manually again the Static IP, the settings are not lost.

[matthijs]

#627 is a duplicate of this bug and is reported for 2.3.6.0.

[matthijs]

This seems to be caused by the following code in /etc/fonststated/UMTS:

    os.execute("killall umtsd.lua")
    uci_state:load("umtsd")
    uci_state:revert("umtsd", "umtsdstate")
    uci_state:save("umtsd")
    if umts == "umts" then
        uci:set("fon", "wan", "mode", "dhcp")
    else
        return
    end

This resets the fon/wan/mode variable to "dhcp" after killing umtsd.lua.

[matthijs]

I implemented a fix for this, which I'll commit in the near future.

[matthijs]

(In [1909]) umtsd: Fix a race condition when unplugging a 3G modem.

Before, when a 3G modem is unplugged, a hotplug script would unset umtsd.umtsd.attached and then call the UMTS fonstated script. The latter would check the attached variable and kill umtsd if it was not set. However, umtsd would periodically rewrite the umtsd state config. Everytime it does so, it also rewrites umtsd.umtsd.attached=1. If this rewriting happened between the resetting of the attached variable in the hotplug script and its reading in the UMTS script, umtsd would not be properly terminated, even though the 3G modem was unplugged.

It seems this race condition was more often triggered with a (still uncommited) fix for #405 in place (for reasons I do not understand).

To fix this, a bunch of code has been moved from the UMTS script to the hotplug script. Now, the hotplug script takes care of most of the stuff UMTS used to do: Killing umtsd.lua (re)setting the wan mode, resetting the umtsd config. UMTS is still used to restart umtsd on configuration changes (since the networking code also kills umtsd when appropriate).

References: #405

[matthijs]

(In [1910]) umtsd: Restore the old internet config after unplugging a 3g modem.

Before, the internet configuration would always be changed to "dhcp", even when it was something else like bridge or static before plugging in the mode. Now, the old mode is saved and restored after unplugging (and on boot, in case the mode is still set to umts from a previous boot).

Closes: #405

[matthijs]

(In [1911]) umtsd: When (re)starting or stopping umtsd, restart all networking.

This is needed to support switching from and to bridge mode, which requires changing the LAN and thus wifi configurations as well. For good measure, also reconfigure OpenVPN. There is no need to restart DDNS, that is handled through iface hotplug scripts.

References: #405

[matthijs]

(In [1912]) umtsd: Empty resolv.conf after unplugging a 3g modem.

This ensures that the dns servers from the 3g connection don't linger around. This wasn't previously a problem, since the Fonera always switched back to dhcp mode, which overwrites the resolv.conf file.

References: #405