[PATCH] LuCI QoS: Upload speed contains "1024kbit" and "1Mbit"

[carsten.schuette@…]

The dropdown list on QoS config page in luci contains "1024kbit" and "1mbit" for upload speed. This is the same ;-)

[matthijs]

This is caused by the way the speeds are generated in [src:trunk/fon/luci/luci/applications/luci-qos/luasrc/model/cbi/qos/qosmini.lua the Qos application]:

for i = 128, 1024, 128 do
    download:value(i, i.." Kb/s")
end
for i = 1, 10 do
    download:value(i * 1024, i.." Mb/s")
end

This generates speeds from 128 to 1024 in 12Kbit increments. This is easily fixed by generating speeds up to 1023 Kbit, or from 2Mbit instead (the previous line is the "PATCH" referenced in the subject...).

Also, to be nitpicky, Mbps usually means 1,000,000 bits per second, not 1024*1024, so 1024Kbit/s is not usually equal to 1Mbit/s. But the current implementation does use 1024 bits in a Kbit, so your point is completely valid :-)

[cyrus]

r1673