Ticket #599 (closed bug: fixed)

Opened 3 years ago

Last modified 3 months ago

[PATCH] LuCI QoS: Upload speed contains "1024kbit" and "1Mbit"

Reported by: carsten.schuette@… Owned by:
Priority: low Milestone:
Component: fon-web Version: 2.3.6.0 (Gari)
Severity:
Cc: Hardware: unknown

Description

The dropdown list on QoS config page in luci contains "1024kbit" and "1mbit" for upload speed. This is the same ;-)

Attachments

Change History

Changed 3 years ago by matthijs

  • status changed from new to confirmed
  • component changed from fon-base-firmware to fon-web
  • summary changed from LuCI QoS: Upload speed contains "1024kbit" and "1Mbit" to [PATCH] LuCI QoS: Upload speed contains "1024kbit" and "1Mbit"
  • hardware set to unknown
  • version set to 2.3.6.0 (Gari)
  • milestone Firmware 2.3.5 deleted

This is caused by the way the speeds are generated in [src:trunk/fon/luci/luci/applications/luci-qos/luasrc/model/cbi/qos/qosmini.lua the Qos application]:

for i = 128, 1024, 128 do
    download:value(i, i.." Kb/s")
end
for i = 1, 10 do
    download:value(i * 1024, i.." Mb/s")
end

This generates speeds from 128 to 1024 in 12Kbit increments. This is easily fixed by generating speeds up to 1023 Kbit, or from 2Mbit instead (the previous line is the "PATCH" referenced in the subject...).

Also, to be nitpicky, Mbps usually means 1,000,000 bits per second, not 1024*1024, so 1024Kbit/s is not usually equal to 1Mbit/s. But the current implementation does use 1024 bits in a Kbit, so your point is completely valid :-)

Changed 3 years ago by cyrus

  • status changed from confirmed to closed
  • resolution set to fixed

Add/Change #599 ([PATCH] LuCI QoS: Upload speed contains "1024kbit" and "1Mbit")

Author


E-mail address and user name can be saved in the Preferences.


Action
as closed
 
Note: See TracTickets for help on using tickets.