Ticket #623 (closed bug: fixed)
[PATCH] Music plugin filebrowser shows garbage due to fon_browser bug
| Reported by: | matthijs | Owned by: | |
|---|---|---|---|
| Priority: | low | Milestone: | Firmware 2.3.7.0 |
| Component: | fon-base-firmware | Version: | 2.3.6.0 (Gari) |
| Severity: | |||
| Cc: | Hardware: | 2.0n (FON2300) |
Description
When browsing the USB disc from the music plugin, there is some garbage before every file (The text "close_a = false" is shown).
This comes from a bug in fon_browser/browser.htm, where some server side code ended up outside of the {% %} tags.
Below patch fixes this issue. After looking at the code, I also believe the issue caused invalid HTML (extra </a> tag), which is also fixed by the patch.
Index: luci/applications/luci-fonbrowser/luasrc/view/fon_browser/browser.htm
===================================================================
--- luci/applications/luci-fonbrowser/luasrc/view/fon_browser/browser.htm (revision 1662)
+++ luci/applications/luci-fonbrowser/luasrc/view/fon_browser/browser.htm (working copy)
@@ -82,9 +82,9 @@
<%-else
if show_href then-%>
<a style="color:#000;" href="<%=object.href%>">
- <%else%>
- close_a = false
- <%end
+ <%else
+ close_a = false
+ end
end
else-%>
<a style="color:#000;" href="<%=object.href%>">
Attachments
Change History
Note: See
TracTickets for help on using
tickets.
