Port forwarding deletion need reboot

[matthijs]

When you configure a port forward in the webgui, the firewall is not reloaded automatically. This needs a manual firewall restart (/etc/init.d/firewall restart) or complete router reboot to work.

This issue is making people think that port forwarding is not working at all (see #820 for example).

[anonymous]

Hello everybody;

since I installed 2.3.6.0 firmware forwarding through the web GUI gives me this error message:

/usr/lib/lua/luci/cbi.lua:316: Unable to read UCI data: firewall stack traceback:

[C]: in function 'error' /usr/lib/lua/luci/cbi.lua:316: in function 'init' /usr/lib/lua/luci/util.lua:68: in function 'Map' /usr/lib/lua/luci/model/cbi/fon_fw/portfwd.lua:4: in function 'func' /usr/lib/lua/luci/cbi.lua:88: in function 'load' /usr/lib/lua/luci/dispatcher.lua:677: in function 'target' /usr/lib/lua/luci/dispatcher.lua:368: in function 'dispatch' /usr/lib/lua/luci/dispatcher.lua:133: in function </usr/lib/lua/luci/dispatcher.lua:132>

Reset router has had no effect; I will try reset to factory default and report here.

grtz Jos

[JoepieNL]

reset to factory worked !

[matthijs]

Ok, good. However, the backtrace you posted is probably unrelated to the actual topic of this report.

Furthermore, considering other reports, the problems with port forwarding might be more complex that just what's stated here. This needs further investigation, though.

[matthijs]

Even though I did report this ticket, I don't actually think what is says is correct. It seems that the firewall is actually reloaded after changing the port forwarding configuration, so adding new port forwardings do take effect immediately. I've tested this with both 2.3.6.1 as well as the latest svn version. I'm not sure why this didn't work before, though.

There is one problem, though: When deleting port forwards, the firewall is not reloaded properly, leaving the old port forwards in effect. Rebooting or adding another port forward fixes this.

I'll leave this ticket open for this particular issue.

[matthijs]

On one occasion, it seems this bug (are at least the same symptom) occured for me when adding a firewall rule. I haven't been able to reproduce it on subsequent tries, though, so no clue if it's a real problem (when adding entries, the problem with deleting entries is identified).

[matthijs]

(In [1916]) luci: Fix event triggering when deleting values.

This removes a check for self.proceed, which seems to be a remnant of old code allowing the user to cancel pending changes (which was not working anyway). Removing this check makes sure that events are triggered when a value is removed from a list (e.g., when a port forward was removed).

Closes: #842